Patch #986 2006-04-08 22:12

karakas

Change wxUSleep() to wxUsleep() in src/sdk/cbthreadpool.cpp
Download
986-Change_wxUSleep.patch (474 bytes)
Category
 
Status
Out of date
Close date
2006-04-10 09:20
Assigned to
 
--- src/sdk/cbthreadpool.cpp    2005-10-25 09:59:02.000000000 +0200
+++ src/sdk/cbthreadpool.cpp    2006-04-03 23:22:00.000000000 +0200
@@ -250,7 +250,7 @@
 #if wxCHECK_VERSION(2,6,0)
     wxMilliSleep(1);
 #else
-    wxUSleep(1);
+    wxUsleep(1);
 #endif
 
     wxLogNull logNo;
@@ -265,7 +265,7 @@
 #if wxCHECK_VERSION(2,6,0)
             wxMilliSleep(1);
 #else
-            wxUSleep(1);
+            wxUsleep(1);
 #endif
             if(++count > 10)
                 break;

History

thomasdenk 2006-04-09 16:53

Although the patch is technically correct (it should indeed be wxUsleep), I think it is no good, anyway.

Unless I am mistaken, you cannot compile Code::Blocks with wxWidgets < 2.6.0 at all (correct me if I am wrong).

But it is a good reminder. We should eventually remove all code parts specific to wxWidgets versions that don't compile anyway.

karakas 2006-04-09 20:55

Well, for the sake of completeness, let me say that yes, I was able to compile Code::Blocks with wxWidgets 2.5.3.1.

However, as I have upgraded to wxWidgets 2.6.3.2 already, I will not pursue this further.

mandrav 2006-04-10 09:20

As mentioned in your relevant bug report, you 're talking about rc2.

In HEAD, wxUsleep() is used already, although it's not used because it can't be built with anything less than wx2.6+.