Patch #3405 2013-01-13 02:57

p2rkw

Don't clear build messages before run
Download
3405-Don_t_clear_bu.patch (1.7 KB)
Category
Plugin::Refinement
Status
Accepted
Close date
2013-01-28 21:20
Assigned to
tpetrov
Index: src/plugins/compilergcc/compilergcc.cpp
===================================================================
--- src/plugins/compilergcc/compilergcc.cpp    (wersja 8784)
+++ src/plugins/compilergcc/compilergcc.cpp    (kopia robocza)
@@ -1536,7 +1543,7 @@
     return wxEmptyString;
 }
 
-void CompilerGCC::DoPrepareQueue(bool clearLog)
+void CompilerGCC::DoPrepareQueue(bool clearLog, bool clearErrors)
 {
     if (m_CommandQueue.GetCount() == 0)
     {
@@ -1545,7 +1552,8 @@
 
         if (clearLog)
             ClearLog();
-        DoClearErrors();
+        if(clearErrors)
+            DoClearErrors();
         // wxStartTimer();
         m_StartTime = wxGetLocalTimeMillis();
     }
@@ -1753,7 +1761,7 @@
     {
         target = m_pProject->GetBuildTarget(m_pProject->GetActiveBuildTarget());
     }
-    DoPrepareQueue();
+    DoPrepareQueue(true, false);
     if (   !(target && (   target->GetTargetType() == ttCommandsOnly // do not require compiler for commands-only target
                         || target->GetCompilerID() == wxT("null") )) // do not require compiler for "No Compiler" (why would you?)
         && !CompilerValid(target) )
Index: src/plugins/compilergcc/compilergcc.h
===================================================================
--- src/plugins/compilergcc/compilergcc.h    (wersja 8784)
+++ src/plugins/compilergcc/compilergcc.h    (kopia robocza)
@@ -178,7 +178,7 @@
         void SaveOptions();
         void LoadOptions();
         void DoRegisterCompilers();
-        void DoPrepareQueue(bool clearLog=true);
+        void DoPrepareQueue(bool clearLog=true, bool clearErrors=true);
         void NotifyCleanProject(const wxString& target);
         void NotifyCleanWorkspace();
         int DoRunQueue();

History

p2rkw 2013-01-13 02:59

If you apply this you will be able to check warnings while application will be starting.

tpetrov 2013-01-20 22:05

Alpha I'm taking this patch, because I can commit it. If you find any problems don't hesitate to state them. I'll test the patch this week and if there are no problems I'll commit.

mortenmacfly 2013-01-21 15:51

FYI: I had it applied for some time now. Its quite convenient, as this was bugging me a very long time, indeed.

alpha0010 2013-01-22 01:03

Sorry, I have been a bit busy recently; it is fine if you take it.

tpetrov 2013-01-22 20:57

This patch, breaks the switching to the debugger's log, when a debug->start is executed, so it requires a bit more polishing. Probably some major changes, should be done on the switching API we have, but I'm currently testing and trying things.

tpetrov 2013-01-28 21:20

Applied with modifications and also fix the annoying issues with the switching, please post in the forum if you see any more switching issues.