Bug #19113 2013-09-05 06:54

mojca

missing #include <string> in CallTip.h

Unless I add #include <string> to src/sdk/wxscintilla/src/scintilla/src/CallTip.h in SVN trunk (revision 9296), the code fails to compile with clang on Mac OS X 10.7 with Xcode 4.6:

In file included from ../../../../codeblocks/src/sdk/wxscintilla/src/ScintillaWX.cpp:30:
In file included from ../../../../codeblocks/src/sdk/wxscintilla/src/ScintillaWX.h:37:
../../../../codeblocks/src/sdk/wxscintilla/src/scintilla/src/CallTip.h:20:14: error: implicit instantiation of undefined template 'std::basic_string<char, std::char_traits<char>,
      std::allocator<char> >'
        std::string val;
                    ^
/usr/include/c++/4.2.1/bits/stringfwd.h:55:11: note: template is declared here
    class basic_string;
          ^
In file included from ../../../../codeblocks/src/sdk/wxscintilla/src/ScintillaWX.cpp:30:
In file included from ../../../../codeblocks/src/sdk/wxscintilla/src/ScintillaWX.h:45:
../../../../codeblocks/src/sdk/wxscintilla/src/scintilla/src/RESearch.h:46:14: error: implicit instantiation of undefined template 'std::basic_string<char, std::char_traits<char>,
      std::allocator<char> >'
        std::string pat[MAXTAG];
                    ^
/usr/include/c++/4.2.1/bits/stringfwd.h:55:11: note: template is declared here
    class basic_string;
          ^
2 errors generated.
make[3]: *** [ScintillaWX.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
mv -f .deps/PlatWX.Tpo .deps/PlatWX.Plo
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all-recursive] Error 1
Category
 
Group
Platform:Mac
Status
Closed
Close date
2013-10-02 17:09
Assigned to
 
ollydbg 2013-09-07 15:14

Hi, mojca, thanks for the bug reports.

I see you send a lot of bug report about C::B on Mac, but as far as I know, we don't have a C::B developer working on Mac OS, so I'm not sure these bug will be fixed soon.

mojca 2013-09-17 06:28

I fully understand. However many of these reports and other problems which I'm experiencing are related to:

- compilation with clang

- compilation against wxWidgets 2.9

There is a high chance that the same failure occurs on linux for this particular report if compiling with clang.

I labeled all the problems as "Mac" because I don't have a linux box (other than on a virtual machine) to verify whether the same problems are present there, but I would be grateful if one of developers could try compiling with clang and wxWidgets 2.9 on a linux machine.

There are also a dozen of pretty active developers in MacPorts community, so in case of questions/doubts one can always turn to them for additional clarifications. There are also three buildbots running on different versions of Mac OS X (currently 10.6, 10.7 and 10.8) where one can verify problems/patches.

I'm aware that many of the reported problems are a bit weird and I don't know solutions to them myself, but adding just #include <string.h> seems trivial and harmless to me. Could at least this problem be fixed to start with?

mojca 2013-09-17 06:35
tpetrov 2013-10-02 17:09

Submit a patch and we can discuss it.