Bug #18546 2012-03-29 19:20

kortmann

CPPCheck fails since revision 7879

CPPCheck fails with an error message about no files to check. There is a file filter in this revision that filters out any c++ file. this Patch seems to repair this bug:


--- C:/DOKUME~1/Martin/LOKALE~1/Temp/CppCheck.cpp-revBASE.svn000.tmp.cpp	Sa Mrz  3 13:37:50 2012
+++ C:/Martins/Freeware/codeblocks/src/plugins/contrib/CppCheck/CppCheck.cpp	Do Mrz 29 19:44:31 2012
@@ -215,11 +215,11 @@
     {
         ProjectFile* pf = *it;
         // filter to avoid including non C/C++ files
-        if (pf->relativeFilename.Mid(2).Lower() == wxT(".c")   ||
-            pf->relativeFilename.Mid(4).Lower() == wxT(".cpp") ||
-            pf->relativeFilename.Mid(3).Lower() == wxT(".cc")  ||
-            pf->relativeFilename.Mid(3).Lower() == wxT(".c++") ||
-            pf->relativeFilename.Mid(4).Lower() == wxT(".cxx") ||
+        if (pf->relativeFilename.Right(2).Lower() == wxT(".c")   ||
+            pf->relativeFilename.Right(4).Lower() == wxT(".cpp") ||
+            pf->relativeFilename.Right(3).Lower() == wxT(".cc")  ||
+            pf->relativeFilename.Right(3).Lower() == wxT(".c++") ||
+            pf->relativeFilename.Right(4).Lower() == wxT(".cxx") ||
             FileTypeOf(pf->relativeFilename) == ftHeader)
         {
             Input.Write(pf->relativeFilename + _T("\n"));
Category
Plugin::Any
Group
Platform:All
Status
Closed
Close date
2012-05-18 22:53
Assigned to
tpetrov
alpha0010 2012-04-28 15:12

Oops... I cannot believe I made a mistake that bad, and did not notice. (I think I need to test more rigorously.)

Submitted patch #3285.

tpetrov 2012-05-18 22:53

Should be fixed in rev 7969.

Thank you for the report...