Patch #855 2006-02-22 18:26

sethjackson

cbEditor.h patch
Download
855-cbEditor_h_patc.patch (469 bytes)
Category
 
Status
Closed
Close date
2006-02-23 10:36
Assigned to
 
Index: C:/CodeBlocks/src/sdk/cbeditor.h
===================================================================
--- C:/CodeBlocks/src/sdk/cbeditor.h    (revision 2061)
+++ C:/CodeBlocks/src/sdk/cbeditor.h    (working copy)
@@ -1,5 +1,5 @@
-#ifndef EDITOR_H
-#define EDITOR_H
+#ifndef CBEDITOR_H
+#define CBEDITOR_H
 
 #include <wx/wxscintilla.h>
 #include <wx/hashmap.h>
@@ -262,4 +262,4 @@
         cbEditorInternalData* m_pData;
 };
 
-#endif // EDITOR_H
+#endif // CBEDITOR_H
thomasdenk 2006-02-22 20:08

Quid ita?

sethjackson 2006-02-22 20:57

?????

thomasdenk 2006-02-22 22:37

Why so? :)

Is there a macro collision?

sethjackson 2006-02-22 22:43

No, but there would be if there was another file called editor.h and someone ifndef'd it with EDITOR_H. It is common practice to ifndef the header file with the name of the header.

Ex:

cbeditor.h #ifndef CBEDITOR_H....

main.h #ifndef MAIN_H.....

Yes it is not a big issue just pointing it out. :)

killerbot 2006-02-23 10:36

patch applied, we even had another header file with the same multi-inclusion protection :

Editor.h from scintilla !!