Patch #2954 2010-03-23 19:43

cryogen

Fixed hex editor menu item positioning
Download
2954-Fixed_hex_edit.patch (1.1 KB)
Category
Plugin::Bugfix
Status
Closed
Close date
2010-03-23 19:56
Assigned to
 
Index: src/plugins/contrib/HexEditor/HexEditor.cpp
===================================================================
--- src/plugins/contrib/HexEditor/HexEditor.cpp    (revision 6195)
+++ src/plugins/contrib/HexEditor/HexEditor.cpp    (working copy)
@@ -137,14 +137,15 @@
         wxString label = item->GetLabel();
         #endif
         label.Replace( _T("_"), _T("") );
-        if ( label.Contains( _("&Open...")) )
+        // Cryogen 23/3/10 Fixed menu positioning. Label text shouldn't contain an ampersand. Adjusted help strings.
+        if ( label.Contains( _("Open...")) )
         {
-            fileMenu->Insert( pos+1, idOpenWithHE, _("Open with HexEditor"), _("Open file using HexEditor") );
+            fileMenu->Insert( pos+1, idOpenWithHE, _("Open with he&x editor"), _("Open file using hex editor") );
             return;
         }
     }
 
-    fileMenu->Append( idOpenWithHE, _("Open with HexEditor"), _("Open file using HexEditor") );
+    fileMenu->Append( idOpenWithHE, _("Open with he&x editor"), _("Open a file using hex editor") );
 }
 
 void HexEditor::OnOpenHexEditFileBrowser( wxCommandEvent& event )
cryogen 2010-03-23 19:45

This patch fixes a bug in the hex editor plug-in that causes the menu item to be appended to the end of the File menu below "Quit".

killerbot 2010-03-23 19:56

applied : thanks for the help.

cryogen 2010-03-24 05:00

Added menu accelerators.