Patch #2611 2008-12-11 18:55

uol

Make HexEditor plugin portable (no C99)
Download
2611-Make_HexEditor.patch (1.5 KB)
Category
Plugin::Bugfix
Status
Accepted
Close date
2010-02-14 06:37
Assigned to
biplab
Index: ExpressionExecutor.cpp
===================================================================
--- ExpressionExecutor.cpp    (Revision 5329)
+++ ExpressionExecutor.cpp    (Arbeitskopie)
@@ -23,7 +23,7 @@
 #include "ExpressionExecutor.h"
 
 #include <wx/intl.h>
-#include <math.h>
+#include <cmath>
 
 namespace Expression
 {
@@ -200,25 +200,25 @@
                 break;
 
             case Operation::fnSin:
-                ReplaceStack( Value( sinl( GetStack().GetFloat() ) ) );
+                ReplaceStack( Value( std::sin( GetStack().GetFloat() ) ) );
                 break;
 
             case Operation::fnCos:
-                ReplaceStack( Value( cosl( GetStack().GetFloat() ) ) );
+                ReplaceStack( Value( std::cos( GetStack().GetFloat() ) ) );
                 break;
 
             case Operation::fnTan:
-                ReplaceStack( Value( tanl( GetStack().GetFloat() ) ) );
+                ReplaceStack( Value( std::tan( GetStack().GetFloat() ) ) );
                 break;
 
             case Operation::fnLn:
-                ReplaceStack( Value( logl( GetStack().GetFloat() ) ) );
+                ReplaceStack( Value( std::log( GetStack().GetFloat() ) ) );
                 break;
 
             case Operation::fnPow:
             {
                 Value p = GetStack(); PopStack();
-                ReplaceStack( Value( powl( GetStack().GetFloat(), p.GetFloat() ) ) );
+                ReplaceStack( Value( std::pow( GetStack().GetFloat(), p.GetFloat() ) ) );
                 break;
             }
 
killerbot 2008-12-29 11:48

seems logic to me.

@Byo : will you apply it ??

mortenmacfly 2009-08-24 07:35

Lieven: please do apply if you want.

byo 2009-08-24 08:38

Morten, Killerbot: can one of you apply this for me? I jumped out of the workflow