Patch #2004 2007-05-12 20:52

rhf

Keyboar shortcuts to Debugger tooltips
Download
2004-Keyboar_shortc.patch (4.0 KB)
Category
Application::Refinement
Status
Rejected
Close date
2013-10-01 20:42
Assigned to
tpetrov
Index: src/plugins/debuggergdb/resources/debugger_toolbar.xrc
===================================================================
--- src/plugins/debuggergdb/resources/debugger_toolbar.xrc    (revision 3960)
+++ src/plugins/debuggergdb/resources/debugger_toolbar.xrc    (working copy)
@@ -2,32 +2,32 @@
 <resource>
   <object class="wxToolBarAddOn" name="debugger_toolbar">
     <object class="tool" name="idDebuggerMenuDebug">
-      <tooltip>Debug / Continue</tooltip>
+      <tooltip>Debug / Continue (F8/Ctrl-F7)</tooltip>
       <longhelp>Debug or continue program (depends on context)</longhelp>
       <bitmap>images/dbgrun.png</bitmap>
     </object>
     <object class="tool" name="idDebuggerMenuRunToCursor">
-      <tooltip>Run to cursor</tooltip>
+      <tooltip>Run to cursor (F4)</tooltip>
       <longhelp>Run program until it reaches the current line</longhelp>
       <bitmap>images/dbgrunto.png</bitmap>
     </object>
     <object class="tool" name="idDebuggerMenuNext">
-      <tooltip>Next line</tooltip>
+      <tooltip>Next line (F7)</tooltip>
       <longhelp>Execute the next line of code</longhelp>
       <bitmap>images/dbgnext.png</bitmap>
     </object>
     <object class="tool" name="idDebuggerMenuNextInstr">
-      <tooltip>Next instruction</tooltip>
+      <tooltip>Next instruction (Alt-F7)</tooltip>
       <longhelp>Execute the next assembly instruction</longhelp>
       <bitmap>images/dbgstepi.png</bitmap>
     </object>
     <object class="tool" name="idDebuggerMenuStep">
-      <tooltip>Step into</tooltip>
+      <tooltip>Step into (Shift-F7)</tooltip>
       <longhelp>Execute the next line of code, but step inside functions</longhelp>
       <bitmap>images/dbgstep.png</bitmap>
     </object>
     <object class="tool" name="idDebuggerMenuStepOut">
-      <tooltip>Step out</tooltip>
+      <tooltip>Step out (Shift-Ctrl-F7)</tooltip>
       <longhelp>Continue execution until the current frame exits</longhelp>
       <bitmap>images/dbgstepout.png</bitmap>
     </object>
Index: src/plugins/debuggergdb/resources/debugger_toolbar_16x16.xrc
===================================================================
--- src/plugins/debuggergdb/resources/debugger_toolbar_16x16.xrc    (revision 3960)
+++ src/plugins/debuggergdb/resources/debugger_toolbar_16x16.xrc    (working copy)
@@ -2,32 +2,32 @@
 <resource>
   <object class="wxToolBarAddOn" name="debugger_toolbar_16x16">
     <object class="tool" name="idDebuggerMenuDebug">
-      <tooltip>Debug / Continue</tooltip>
+      <tooltip>Debug / Continue (F8/Ctrl-F7)</tooltip>
       <longhelp>Debug or continue program (depends on context)</longhelp>
       <bitmap>images/16x16/dbgrun.png</bitmap>
     </object>
     <object class="tool" name="idDebuggerMenuRunToCursor">
-      <tooltip>Run to cursor</tooltip>
+      <tooltip>Run to cursor (F4)</tooltip>
       <longhelp>Run program until it reaches the current line</longhelp>
       <bitmap>images/16x16/dbgrunto.png</bitmap>
     </object>
     <object class="tool" name="idDebuggerMenuNext">
-      <tooltip>Next line</tooltip>
+      <tooltip>Next line (F7)</tooltip>
       <longhelp>Execute the next line of code</longhelp>
       <bitmap>images/16x16/dbgnext.png</bitmap>
     </object>
     <object class="tool" name="idDebuggerMenuNextInstr">
-      <tooltip>Next instruction</tooltip>
+      <tooltip>Next instruction (Alt-F7)</tooltip>
       <longhelp>Execute the next assembly instruction</longhelp>
       <bitmap>images/16x16/dbgstepi.png</bitmap>
     </object>
     <object class="tool" name="idDebuggerMenuStep">
-      <tooltip>Step into</tooltip>
+      <tooltip>Step into (Shift-F7)</tooltip>
       <longhelp>Execute the next line of code, but step inside functions</longhelp>
       <bitmap>images/16x16/dbgstep.png</bitmap>
     </object>
     <object class="tool" name="idDebuggerMenuStepOut">
-      <tooltip>Step out</tooltip>
+      <tooltip>Step out (Shift-Ctrl-F7)</tooltip>
       <longhelp>Continue execution until the current frame exits</longhelp>
       <bitmap>images/16x16/dbgstepout.png</bitmap>
     </object>

History

rhf 2007-05-12 21:00

I put this is the category Application::Refinement.

It probably should have been in Plugin::Refinement.

Bob

mandrav 2007-05-22 09:38

I appreciate this but I see two problems:

- the same should be done for all toolbar items (not debugger's only) for consistency

- if the user re-assigns the shortcuts then the tooltips will display invalid information (that's the reason no shortcuts are displayed in tooltips atm)

rhf 2007-05-22 13:01

I agree completely with your comments.

(1) If there was interest, I was/am willing to commit to doing the same for all of the applicable tooltips. (As I am not one of your developers, I wasn't sure if this would be appreciated.)

(2) I had exactly the same concern regarding user re-assignments. However, the drop down menus also have hard-coded shortcuts - I think. I expected them to be tied in some way to the user assignments, but when they did not appear to be so, I went ahead and prepared the tooltip patches.

Clearly the "correct" way to do this is to make all shortcuts, in menus and tooltips, dependent on user assignments. I don't know enough about CB to do this but would be willing to work on it with some guidance.

tpetrov 2013-10-01 20:42

We need better mechanism for putting shortcuts in the tooltips.