Patch #1632 2006-11-10 04:10

heromyth

For more strings which can be translated
Download
1632-For_more_strin.patch (113.3 KB)
Category
Translation
Status
Rejected
Close date
2006-11-25 09:42
Assigned to
 
Index: src/plugins/codecompletion/codecompletion.cpp
===================================================================
--- src/plugins/codecompletion/codecompletion.cpp    (revision 3196)
+++ src/plugins/codecompletion/codecompletion.cpp    (working copy)
@@ -203,7 +203,7 @@
         m_EditMenu->Append(idMenuShowCallTip, _("Show call tip\tCtrl-Shift-Space"));
     }
     else
-        Manager::Get()->GetMessageManager()->DebugLog(_T("Could not find Edit menu!"));
+        Manager::Get()->GetMessageManager()->DebugLog(_("Could not find Edit menu!"));
     pos = menuBar->FindMenu(_("Sea&rch"));
     if (pos != wxNOT_FOUND)
     {
@@ -211,7 +211,7 @@
         m_SearchMenu->Append(idMenuGotoFunction, _("Goto function...\tCtrl-Alt-G"));
     }
     else
-        Manager::Get()->GetMessageManager()->DebugLog(_T("Could not find Search menu!"));
+        Manager::Get()->GetMessageManager()->DebugLog(_("Could not find Search menu!"));
 
     // add the classbrowser window in the "View" menu
     int idx = menuBar->FindMenu(_("View"));
@@ -294,13 +294,13 @@
                         subMenu->Append(idUnimplementedClassMethods, _("All class methods without implementation..."));
                     }
                     else
-                        Manager::Get()->GetMessageManager()->DebugLog(_T("Could not find Insert menu 3!"));
+                        Manager::Get()->GetMessageManager()->DebugLog(_("Could not find Insert menu 3!"));
                 }
                 else
-                    Manager::Get()->GetMessageManager()->DebugLog(_T("Could not find Insert menu 2!"));
+                    Manager::Get()->GetMessageManager()->DebugLog(_("Could not find Insert menu 2!"));
             }
             else
-                Manager::Get()->GetMessageManager()->DebugLog(_T("Could not find Insert menu!"));
+                Manager::Get()->GetMessageManager()->DebugLog(_("Could not find Insert menu!"));
         }
     }
 }
@@ -411,7 +411,7 @@
     Parser* parser = m_NativeParsers.FindParserFromEditor(ed);
     if (!parser)
     {
-        Manager::Get()->GetMessageManager()->DebugLog(_T("Active editor has no associated parser ?!?"));
+        Manager::Get()->GetMessageManager()->DebugLog(_("Active editor has no associated parser ?!?"));
         return -4;
     }
 
@@ -423,14 +423,14 @@
     {
 #ifdef DEBUG_CC_AI
         if (s_DebugSmartSense)
-            Manager::Get()->GetMessageManager()->DebugLog(_T("%d results"), result.size());
+            Manager::Get()->GetMessageManager()->DebugLog(_("%d results"), result.size());
 #endif
         size_t max_match = cfg->ReadInt(_T("/max/matches"), 16384);
         if (result.size() <= max_match)
         {
 #ifdef DEBUG_CC_AI
             if (s_DebugSmartSense)
-                Manager::Get()->GetMessageManager()->DebugLog(_T("Generating tokens list"));
+                Manager::Get()->GetMessageManager()->DebugLog(_("Generating tokens list"));
 #endif
             wxImageList* ilist = parser->GetImageList();
             ed->GetControl()->ClearRegisteredImages();
@@ -489,7 +489,7 @@
 
 #ifdef DEBUG_CC_AI
             if (s_DebugSmartSense)
-                Manager::Get()->GetMessageManager()->DebugLog(_T("0 results"));
+                Manager::Get()->GetMessageManager()->DebugLog(_("0 results"));
 #endif
             if (items.GetCount() == 0)
                 return -2;
@@ -500,7 +500,7 @@
                 items.Sort(SortCCList);
 #ifdef DEBUG_CC_AI
             if (s_DebugSmartSense)
-                Manager::Get()->GetMessageManager()->DebugLog(_T("Done generating tokens list"));
+                Manager::Get()->GetMessageManager()->DebugLog(_("Done generating tokens list"));
 #endif
             ed->GetControl()->AutoCompSetIgnoreCase(!caseSens);
             ed->GetControl()->AutoCompSetCancelAtStart(true);
@@ -525,7 +525,7 @@
     {
 #ifdef DEBUG_CC_AI
         if (s_DebugSmartSense)
-            Manager::Get()->GetMessageManager()->DebugLog(_T("0 results"));
+            Manager::Get()->GetMessageManager()->DebugLog(_("0 results"));
 #endif
         if (!parser->Done())
         {
@@ -680,7 +680,7 @@
     }
     if (!definition.IsEmpty())
         ed->GetControl()->CallTipShow(pos, definition);
-//    Manager::Get()->GetMessageManager()->DebugLog(_T("start=%d, end=%d"), start, end);
+//    Manager::Get()->GetMessageManager()->DebugLog(_("start=%d, end=%d"), start, end);
     // only highlight current argument if only one calltip (scintilla doesn't support multiple highlighting ranges in calltips)
     ed->GetControl()->CallTipSetHighlight(count == 1 ? start : 0, count == 1 ? end : 0);
 }
@@ -704,7 +704,7 @@
     Parser* parser = m_NativeParsers.FindParserFromActiveEditor();
     if (!parser)
     {
-        Manager::Get()->GetMessageManager()->DebugLog(_T("Active editor has no associated parser ?!?"));
+        Manager::Get()->GetMessageManager()->DebugLog(_("Active editor has no associated parser ?!?"));
         return -4;
     }
 
@@ -753,7 +753,7 @@
download for full patch...
mandrav 2006-11-25 09:42

Sorry, but this patch has to be rejected.

Debugging messages and messages that are printed using MessageManager::DebugLog() must NOT be translated.

The debug log is not visible to the user, not unless explicitely enabled anyway. And the point is that in case of problems we can ask the user to paste the contents of the debug log for us to check. Now, how would we understand the debug log if it was in Chinese/Swahili/AnyOtherLanguage???