Bug #8784 2006-09-13 11:06

blokley

Tab button text color predefined

I use darker than normal window background (Windows) and it seems that codeblocks respects that by using it,

but codeblocks doesn't seem to read the button's (tab buttons "build messages", "build log" etc.) text color from system set colors.. Thus I end up having hard time seeing what it says on the tabs.

( http://img208.imageshack.us/my.php?image=hardtoseerq0.png )

Could codeblocks a) read the value from some system set color b) let the user specify the color c) both

I'm using "11 september 2006 build" (though it was present in "06 september 2006 build" when I first tried a nightly build.

Category
Application::Interface
Group
 
Status
Closed
Close date
2007-02-05 11:32
Assigned to
 

History

dermeister 2006-09-13 22:17
This is a problem of wxFlatNotebook, thus I don't think the C::B developers will solve this as long as it is not solved in the source of wxFlatNotebook.

In fact, wxFlatNotebook already uses the system defined color for the buttons. But it only uses it for active tabs. Inactive tabs simply get "GREY" as color.

Anyway, here is a small patch that might solve your problem if you compile Code::Blocks yourself:

Index: src/sdk/wxFlatNotebook/wxFlatNotebook.cpp
===================================================================
--- src/sdk/wxFlatNotebook/wxFlatNotebook.cpp   (revision 2970)
+++ src/sdk/wxFlatNotebook/wxFlatNotebook.cpp   (working copy)
@@ -1057,7 +1057,7 @@           
                                
        wxWindow::Create(parent, id, pos, size, style | wxNO_BORDER | wxNO_FULL_REPAINT_ON_RESIZE);
                                
-       m_nonActiveTextColor = wxT("GREY");
+       m_nonActiveTextColor = wxColor(wxSystemSettings::GetColour(wxSYS_COLOUR_INACTIVECAPTIONTEXT));
        m_pDropTarget = new wxFNBDropTarget<wxPageContainerBase>(this, &wxPageContainerBase::OnDropTarget);
        SetDropTarget(m_pDropTarget);
 }

I'm not 100% sure if wxSYS_COLOUR_INACTIVECAPTIONTEXT is the right color - just take a look at http://www.wxwindows.org/manuals/2.6.3/wx_wxsystemsettings.html#wxsystemsettingsgetcolour and pick another one if it is not the correct color.
dermeister 2006-10-14 21:39

Forget about this patch, it can't be applied anymore.

artoj 2007-01-19 21:12

Works for me (the tab's title color is not predefined).

Windows XP x64, wxMSW 2.6.3p2, rev 3504.

artoj 2007-02-05 11:32

Closing as no response for weeks + works for me. If the bug still persists, create a new report (testing with the latest revision).

Thank you for the bug report.