Bug #19053 2013-07-12 01:11

mberchtold

Incorrect Scintilla!AutoComplete.cxx patch

The autocomplete window in Scintilla is created each time but not destroyed.

This results in a window leak and in the case Scintilla.dll is manually unloaded a crash.

Your patch:

void AutoComplete::Start(Window &parent, int ctrlID,

int position, Point location, int startLen_,

int lineHeight, bool unicodeMode, int technology) {

/* C::B begin */

// if (active) {

// Cancel();

// }

/* C::B end */

lb->Create(parent, ctrlID, location, lineHeight, unicodeMode, technology);

lb->Clear();

...

void AutoComplete::Cancel() {

if (lb->Created()) {

lb->Clear();

/* C::B begin */

//lb->Destroy();

lb->Show(false);

/* C::B end */

active = false;

}

}

Original Code:

void AutoComplete::Start(Window &parent, int ctrlID,

int position, Point location, int startLen_,

int lineHeight, bool unicodeMode, int technology) {

if (active) {

Cancel();

}

lb->Create(parent, ctrlID, location, lineHeight, unicodeMode, technology);

lb->Clear();

active = true;

startLen = startLen_;

posStart = position;

}

Category

Application::Error

Group

Platform:Windows

Status

Open

Close date

 

Assigned to