Bug #12823 2008-01-01 00:34

jenslody

keybinder breaks layout submenu on linux

If the checkable MenuItems (this are the named layouts) in "View -> Layouts" have no keyboard shortcut and the keybinder-plugin is enabled, switching to a layout does not set the check-mark on linux.

If a layout is saved without changing the name it appears as new MenuItem in the Menu.

After restart of C::B the correct number of menuitems is shown.

This happens, because keybinder adds a space to the end of the Label.

The space is wanted, because wxWidgets did not update the MenuItem otherwise.

This behaviour seems to be fixed in wxWidgets 2.8.7, so it's not longer needed.

I changed "menuutils.cpp" to use the same code for GTK and MSW (except the rebuilding of bitmapped menuitems) and it seems to work on Linux and on Win2K (both wxWidgets 2.8.7).

Maybe it also works on Mac, but I cannot test it.

I will submit a patch and add the patch-number here.

Regards Jens

Category
Application::WrongBehaviour
Group
 
Status
Closed
Close date
2008-02-12 18:19
Assigned to
pecan
jenslody 2008-01-01 01:45

Patch number is #2308

pecan 2008-01-01 13:32

Would you update your patch to use the 2.8.7 guards. Since others use 2.8.x, this code cannot be applied without the guards.

jenslody 2008-01-01 20:19

patch is updated

pecan 2008-02-12 18:19

Fixed svn 4874

Thanks for the report